Move DateFields::month_code over to being a byte slice #7116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
month-bytes
branch
from
dd049e8 to
5eae8bf
Compare
This was referenced Oct 16, 2025
sffc
reviewed
Oct 16, 2025
|
That was my conclusion too. It's a bit of a bummer to lose the readability of the old new_normal, new_leap APIs though |
|
I'm overall quite convinced by the "from_fields should accept anything" argument so even if we had ValidMonthCode already designed and graduated I would not want to use it here anyway. |
|
Also note: this PR doesn't yet fix the Debug impl but it's an easy addition I'll do soon. |
Manishearth
force-pushed
the
month-bytes
branch
from
5eae8bf to
7f4ce11
Compare
|
(undid the force push, the new Debug commit is the only new thing) |
Manishearth
force-pushed
the
month-bytes
branch
2 times, most recently
from
c2b2dba to
a3d99e0
Compare
|
🎉 All dependencies have been resolved ! |
Manishearth
force-pushed
the
month-bytes
branch
from
a3d99e0 to
b67e031
Compare
sffc
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7115, depends on #7105
Attempt at fixing #7104.
The user experience of the byte slice is a little bit worse if you want to use MonthCode::new_normal/new_leap since you have to persist those for a while.
Most people will not be creating them for long, though. In theory we could produce byte versions of those methods that produce a limited range of codes. It's more a problem for our tests that need to do things like "create many codes in a loop".